refactor(web): extract function, rename variables#16063
Merged
Conversation
Build-bot: skip Test-bot: skip
Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
previously approved these changes
Jun 8, 2026
| * See https://help.keyman.com/developer/engine/web/current-version/reference/core/setKeyboardForControl | ||
| * | ||
| * @param {Element} elem The control element to be managed manually | ||
| * @param {string|null=} keyboard JSKeyboard (Clears the set keyboard if set to null) |
Member
There was a problem hiding this comment.
This comment doesn't make sense to me - JSKeyboard doesn't describe what the parameter should be (if we are cleaning up we should fix it!)
| * | ||
| * @param {Element} elem The control element to be managed manually | ||
| * @param {string|null=} keyboard JSKeyboard (Clears the set keyboard if set to null) | ||
| * @param {string|null=} languageCode Language Code |
Member
There was a problem hiding this comment.
This also needs more clarity - what is the languageCode for? It doesn't make it clear that this needs to be part of a pair with the keyboard parameter to find a registered keyboard+language.
| _name = ''; | ||
| _lgCode=''; | ||
| private async selectKbd(kbdIndex: number): Promise<boolean> { | ||
| let name, languageCode; |
mcdurdin
approved these changes
Jun 9, 2026
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.244-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-bot: skip